Units / topology

topology.proto_topology_p1 partial

Layer

32

Upstream lines

2,746

Functions

180

Rust module

topology::proto_topology::p1

Source: crates/solidcore/src/topology/proto_topology/p1.rs

Upstream: source/SMLib/inc/SmAssembly.h, source/SMLib/inc/SmAssemblyInstance.h, source/SMLib/inc/SmCopyBrepMap.h, source/SMLib/inc/SmOwningTopology.h, source/SMLib/inc/SmProtoTopology.h, source/SMLib/src/SmAssembly.cpp, source/SMLib/src/SmAssemblyInstance.cpp, source/SMLib/src/SmCopyBrepMap.cpp, source/SMLib/src/SmOwningTopology.cpp, source/SMLib/src/SmProtoTopology.cpp, source/SM_API/src/SmApiGeneral.cpp

Notes

PARTIAL: current numbers (after PR #144; fresh run in PR #154): difftest cases=1857 passed=1765 failed=0 deferred=92 (topology.brep_p5 10, topology.edge 28, topology.face_p2 29, topology.vertex 25), max_rel_err 0, --perturb SENSITIVE 1765/1765. Original port (history, superseded by the numbers above): difftest 1601 cases (14 upstream-derived fixtures from SM_API_test TestSmGeneral.cpp transforms, 87 edge cases built in code: list walks, assemblies, the proto life cycle at unit/huge/tiny scale, manager destructor, every API call on line/B-spline/circle/plane/composite/crv-on-surf/other/null; 1500 generated list/proto/transform scripts), 1446 pass bit-identical (max_rel_err 0), 155 deferred (surface.surface_point_solve_p3 56, topology.edge 29, topology.face_p2 26, topology.vertex 25, topology.brep_p5 10, query.poly 9; SmProtoVertex::ContainsPoint wired by query.face_p2); --perturb SENSITIVE. Upstream defects found: UB-98 (SmCopyBrepMap release SM_ASSERT null deref), HANG-12 (DropPoint after zero-length Reparameterize; Rust curve point solve loops too), WR-73 (RemoveCoincidentNoEdgeProtoVertex returns SM_SUCCESS as TRUE, kept for parity). Wired UNPORTED(topology.proto_topology_p1) in topology.topology (SmTopology destructor -> destroy_topology; stays green 657/657) and the topology.edgeuse_p1 co-port of SmOwningTopology::IsKindOf (unchanged 2449 pass/273 deferred). Plan notes: 180 fns; largest: sm_AreOverlapping, SmProtoTopologyManager::CanCombineEdgeDefinitions, SmProtoTopologyManager::RemoveCoincidentNoEdgeProtoVertex, sm_TransformIndependentObject; entry points: SmApiRotate, SmApiScale, SmApiScaleByPt, SmApiTransform, SmApiTranslate; cycle back-edges (call into later units; stub or co-port): query.poly(9), topology.edge(7), query.face_p2(4), blend.fillet_geom_p1(3), topology.edgeuse_p1(3), topology.vertex(3), topology.shell(2), boolean.topology_intersector_p1(1), topology.brep_p1(1), topology.brep_p2(1), topology.brep_p3(1), topology.brep_p4(1), topology.brep_p5(1), topology.face_p4(1), topology.vertexuse(1); unit-SCC #22 (220 units); 319 upstream test entry points reach this unit; CO-PORTED in topology.edgeuse_p1 (PR #55): SmOwningTopology::IsKindOf -> topology::edgeuse::p1::owning_topology_is_kind_of; CO-PORTED in query.poly (PR #73): SmOwningTopology::IsKindOf -> query::poly::owning_topology_is_kind_of (private); SmOwningTopology PostInsert/Remove/GetAll list semantics are re-implemented for poly lists inside query::poly::PolyBrep (Vec / intrusive edge links), not a general port. Re-run after merging PR #106 (surface.surface_point_solve_p3 wired, 2026-10-15): 1601 cases, 1494 pass, 107 deferred (query.poly 9, topology.brep_p5 10, topology.edge 33, topology.face_p2 28, topology.vertex 27), 0 failed, max_rel_err 0. [PR #114: the proto-script engine (shim, ffi validation, runner) also carries the ops 91-108 of topology.proto_topology_p2; this unit's generator and report are unchanged] PR #144 (2026-10-16): wired this unit's UNPORTED(topology.vertex/topology.edge/query.poly) stubs: sm_AreConnected, SmProtoVertex::GetFinalVertex and sm_FindEDOnDegenFace now walk the B-rep through the ProtoTopology trait (Brep over EntityRef via topology.vertex/vertexuse/edge/edgeuse_p1; sm_FindEDOnDegenFace stops at UNPORTED(topology.face_p4) SmFace::GetEdges for a shared face), SmApiTransform moves poly B-reps through query.poly PolyBrep::transform (transform scripts gain poly B-reps with 1-4 vertices, tobj 9, reporting tolerance and vertices; 36 new edge cases). difftest: cases=1637 passed=1545 failed=0 deferred=92 (topology.brep_p5 10, topology.edge 28, topology.face_p2 29, topology.vertex 25: all from intersect.point_class / curve_class stubs or SmBrep::Transform), max_rel_err 0; --perturb SENSITIVE. topology.proto_topology_p2 re-run: 1533 cases, 1247 pass, 286 deferred, 0 failed. After merging main with topology.proto_topology_p3 (PR #121): ProtoBrep drops its own vertex_point / edge_faces / edge_other_vertex in favour of those of its supertrait ProtoTopology (one difftest Pool impl, a VertexAt vertex reports its point); p1 unchanged (1637/1545/92), topology.proto_topology_p3 re-run: cases=3013 passed=2638 failed=0 deferred=375 (query.brep 70, topology.edge 95, topology.face_p2 94, topology.vertex 116), --perturb SENSITIVE. Review fixes (PR #144, 2026-10-16): removed a no-op drop (clippy drop_non_drop under --features difftest/cpp), restored the Deviations note that sm_FindEDOnDegenFace is unreachable from CanCombineEdgeDefinitions, added fixtures review_poly_transform.json (216 poly B-rep transforms) and review_final_vertex.json (4 GetFinalVertex / AreConnected / CanCombine scripts at scales 1, 1e8, 1e-8, 1e3): cases=1857 passed=1765 failed=0 deferred=92 (topology.brep_p5 10, topology.edge 28, topology.face_p2 29, topology.vertex 25), max_rel_err 0; --perturb SENSITIVE (1765/1765); p2 1533/1247/286 and p3 3013/2638/375 unchanged, 0 failed. The real-B-rep walks of AreConnected / GetFinalVertex / FindEDOnDegenFace are checked only by the unit test brep_walks (plan/findings.md).; CO-PORTED in topology.shell (PR #154): SmOwningTopology::Remove + PostInsert of a face use on the typed Brep face-use list -> topology::shell::move_faceuse (used by SmShell::TransferChildrenTo and SmTopologyTraverser::FaceuseShellReplacement); SmOwningTopology::Remove of a shell from its region -> topology::shell::region_remove_shell (inline in SmOwningTopology.h; no caller left on main)

Difftest

Cases

1,857

Passed

1,765

Deferred

92

Failed

0

Both errored

0

Max rel. error

0.0

Tolerance

1e-09 rel.

Seeds

16

Blocked by

Report JSON (per-case results)

Dependencies

Depends on: curve.curve_p2 green geom.a_object partial geom.axis2_placement green geom.extent1d green geom.object partial geom.tol green geom.vector3d green intersect.curve_class_p1 partial intersect.point_class partial surface.surface_p2 partial topology.topology green

Soft dependencies: curve.curve_p1 partial curve.curve_p6 green geom.solution_array partial

Dependents: blend.fillet_geom_p1 claimed blend.fillet_geom_p3 todo blend.fillet_geom_p5 todo boolean.merge_p1 partial boolean.topology_intersector_p1 partial boolean.topology_intersector_p2 claimed query.poly partial topology.brep_p1 claimed topology.brep_p10 claimed topology.brep_p2 claimed topology.brep_p3 claimed topology.brep_p4 claimed topology.brep_p5 claimed topology.brep_p6 claimed topology.brep_p7 claimed topology.brep_p9 claimed topology.edge partial topology.edgeuse_p1 partial topology.proto_topology_p2 partial topology.proto_topology_p3 partial topology.shell partial topology.vertex partial

Soft dependents: blend.fillet_corner_p1 todo blend.fillet_corner_p2 todo blend.fillet_corner_p3 todo blend.fillet_executive_p1 todo blend.fillet_executive_p2 todo blend.fillet_solver_p1 claimed blend.fillet_solver_p2 todo offset.offset_executive_p2 claimed topology.face_p1 partial topology.loopuse partial topology.topology_traverser partial topology.trimming_tools partial

Upstream functions

Upstream tests reaching this unit

prog_test:my_test_extent3d, prog_test:my_test_vector2d, prog_test:my_test_surface_closest_point, prog_test:my_test_drop_point, prog_test:my_test_matrix, prog_test:my_test_reversed_line_join