Units / surface

surface.surface_p2 partial

Layer

21

Upstream lines

2,398

Functions

91

Rust module

surface::surface::p2

Source: crates/solidcore/src/surface/surface/p2.rs

Upstream: source/SMLib/inc/SmSurface.h, source/SMLib/src/SmSurface.cpp

Notes

surface.surface_p10 (PR #93): LsiGlobalSolver gained the borrowed fields surface_cache and kernel its LocalSolve reads (None from LsiGlobalSolver::new); local_solve now calls LsiGlobalSolver::local_solve_branch (surface::surface::p10). PARTIAL: difftest 869 cases (69 fixture: Surface.sms / DropCurveSurface.sms / offset_nurb.sms queries, evaluation, knots, edits, copies, SmSurfaceEval, ReadFromDB; base SmSurface() defaults; TestSmPrincipalDirectionPairing; + 800 generated), 790 pass bit-identical, 79 deferred after surface.plane_p2 wired the plane dispatch, PR #40 (surface.surface_p5 36, surface.surface_p1 31, surface.cone_p2 10, intersect.adv_surface_intersector 1, topology.trimming_tools 1; the 18 surface.surface_p7 cases moved to surface.surface_p1 with PR #24); wired UNPORTED(surface.surface_p2) in nurbs.b_spline_surface_p1 (IsKindOf), curve.curve_p2, curve.tangent_field, nurbs.b_spline_curve_n_lib, curve.iso_curve, curve.crv_on_surf (ReadFromDB, lift co-ports), nurbs.b_spline_surface_n_lib_p2 (GetDerivativeLimit co-port); geom.grid now blocked on surface.surface_cache_p1; geom.solution_array keeps 2 handle-lookup markers; 91 fns; largest: SmDerivSurfDefinition::CreateCrossSectionCurves, smsurf_EvaluateGeometric, smsurf_DropVectors, sm_CCLocalSolve; cycle back-edges (call into later units; stub or co-port): intersect.curve_class_p1(5), intersect.point_class(3), intersect.surface_intersector_p1(3), intersect.adv_surface_intersector(2), surface.cone_p1(2), surface.surface_cache_p1(2), topology.trimming_tools(2), intersect.curve_class_p2(1), intersect.curve_class_p8(1), intersect.surface_intersector_p4(1), intersect.surface_intersector_p5(1), surface.curve_bounded_surface(1), surface.offset_surface(1), surface.plane_p2(1), surface.sphere(1), surface.srf_in_volume(1), surface.surf_of_extrusion_p2(1), surface.surf_of_revolution_p3(1), surface.surface_p1(1), surface.torus(1); unit-SCC #22 (220 units); 320 upstream test entry points reach this unit intersect.surface_intersector_p5 wired (PR #82): base_global_surface_intersect runs DoIntersection, whose surface caches defer at SmSurface::CalculateContinuities (surface.surface_p6); now 869 cases, 808 pass, 61 deferred (surface.surface_p5 36, surface.surface_p4 13, surface.cone_p2 10, surface.surface_p6 1, topology.trimming_tools 1). [surface.surface_p6 wired (PR #92): 869 cases, 808 pass, 61 deferred (surface.cone_p2 10, surface.surface_p4 13, surface.surface_p5 36, surface.surface_p8 1, topology.trimming_tools 1)] Re-run with surface.surface_p5's back-edges wired (PR #50): cases=869 passed=807 failed=0 deferred=62 max_rel_err=0e0 blocked_by=intersect.adv_surface_intersector(1),surface.plane_p2(11),surface.surface_p3(36),surface.surface_p4(13),topology.trimming_tools(1). Re-run (PR #52, after merging surface_p4/#49 and surface_p5/#50): 869 cases, 844 pass, 25 deferred (surface.surface_point_solve_p3 13, surface.cone_p2 10, surface.surface_p8 1, topology.trimming_tools 1); the generator skips CreateExtendedSurface cases whose in-place N_SrfExtendByDist would be retried on half-written arrays (upstream UB-107, plan/findings.md). surface.surface_point_solve_p3 (PR #106): clone_for_evaluation preserves the owner and exact B-spline/revolution NURBS data for temporary solver evaluation instead of the upstream copy constructor knot fix-up. Re-run after merging PR #106 (surface.surface_point_solve_p3 wired, 2026-10-15): 869 cases, 857 pass, 12 deferred (surface.cone_p2 10, surface.surface_p8 1, topology.trimming_tools 1), 0 failed, max_rel_err 0. [topology.trimming_tools wired (PR #124): CreatePlaneWith3DCurves calls the ported OrderCurvesIntoLoops/FindOuterLoops; re-run after merging main with PR #106: 869 cases, 858 pass, 11 deferred (surface.cone_p2 10, surface.surface_p8 1), 0 failed, max_rel_err 0]

Difftest

Cases

869

Passed

859

Deferred

10

Failed

0

Both errored

0

Max rel. error

0.0

Tolerance

1e-09 rel.

Seeds

16

Blocked by

Report JSON (per-case results)

Dependencies

Depends on: geom.a_object partial geom.assert_array green geom.extent1d green geom.extent2d green geom.extent3d green geom.geom_utility_p1 green geom.object partial geom.solution_array partial geom.tol green geom.vector2d green geom.vector3d green

Soft dependencies: curve.curve_cache green curve.curve_p2 green curve.curve_p3 green curve.curve_p7 green curve.curve_p8 green geom.axis2_placement green geom.polar_box green geom.polynomial green geom.tree partial nurbs.b_spline_curve_n_lib green nurbs.b_spline_curve_p1 green nurbs.b_spline_surface_n_lib_p2 partial nurbs.b_spline_surface_p1 green nurbs.b_spline_surface_p2 partial

Dependents: blend.fillet_corner_p1 todo blend.fillet_corner_p2 todo blend.fillet_corner_p3 todo blend.fillet_executive_p1 todo blend.fillet_geom_p1 claimed blend.fillet_geom_p2 todo blend.fillet_geom_p4 todo blend.fillet_geom_p5 todo blend.fillet_geom_p6 todo blend.fillet_intersector claimed blend.fillet_solver_p1 claimed blend.fillet_solver_p2 todo blend.fillet_solver_p3 todo blend.fillet_solver_p4 claimed blend.fillet_standard_solver_p1 claimed blend.fillet_standard_solver_p2 todo blend.hcr claimed heal.gap partial intersect.adv_surface_intersector partial intersect.curve_class_p1 partial intersect.curve_class_p2 claimed intersect.curve_class_p5 partial intersect.curve_class_p8 partial intersect.curve_class_p9 partial intersect.point_class partial intersect.ray_tracer partial intersect.surface_drop_curve partial intersect.surface_drop_lib_p1 partial intersect.surface_drop_lib_p3 claimed intersect.surface_intersector_p1 partial intersect.surface_intersector_p2 partial intersect.surface_intersector_p3 partial intersect.surface_silhouette green intersect.topology_solver_p1 partial offset.offset_executive_p1 claimed offset.offset_executive_p2 claimed offset.offset_geometry_creation claimed primitive.primitive_creation_p1 claimed query.face_p1 claimed query.face_p3 claimed surface.cone_p1 green surface.cone_p2 claimed surface.cone_p3 partial surface.curve_bounded_surface green surface.offset_surface green surface.plane_p1 partial surface.plane_p2 partial surface.sphere green surface.srf_in_volume partial surface.surf_of_extrusion_p1 green surface.surf_of_extrusion_p2 partial surface.surf_of_revolution_p1 green surface.surf_of_revolution_p2 partial surface.surf_of_revolution_p3 partial surface.surface_cache_p1 green surface.surface_cache_p2 partial surface.surface_cache_p3 partial surface.surface_p1 partial surface.surface_p10 partial surface.surface_p11 partial surface.surface_p3 green surface.surface_p4 green surface.surface_p5 green surface.surface_p6 green surface.surface_p7 partial surface.surface_p8 partial surface.surface_p9 partial surface.surface_point_solve_p1 green surface.surface_point_solve_p2 green surface.surface_point_solve_p3 green surface.torus green sweep.rotational_sweep_geometry partial sweep.trans_sweep_geometry partial topology.brep_p1 claimed topology.brep_p10 claimed topology.brep_p2 claimed topology.brep_p3 claimed topology.brep_p5 claimed topology.brep_p7 claimed topology.brep_p8 claimed topology.brep_p9 claimed topology.edge partial topology.edgeuse_p1 partial topology.edgeuse_p2 partial topology.edgeuse_p3 claimed topology.face_p1 partial topology.face_p2 partial topology.face_p3 claimed topology.proto_topology_p1 partial

Soft dependents: blend.fillet_custom_solver partial blend.fillet_executive_p2 todo blend.fillet_executive_p3 todo blend.fillet_solver_p5 claimed boolean.merge_p1 partial boolean.merge_p2 todo boolean.merge_p3 todo boolean.topology_intersector_p1 partial boolean.topology_intersector_p3 claimed heal.face_props partial heal.heal_data_p3 partial intersect.curve_class_p4 claimed intersect.surface_intersector_p4 partial intersect.surface_intersector_p5 partial intersect.surface_tracer partial intersect.topology_solver_p2 partial primitive.primitive_creation_p2 todo primitive.primitive_creation_p3 todo query.api_queries partial query.brep claimed query.edge partial query.face_p2 partial query.loop green query.poly partial query.tess partial surface.trim_srf_cache partial sweep.topology_sweep claimed topology.brep_cache partial topology.brep_data partial topology.brep_p4 claimed topology.brep_p6 claimed topology.face_p4 claimed topology.loopuse partial topology.proto_topology_p2 partial topology.trimming_tools partial topology.vertexuse partial

Upstream functions

Upstream tests reaching this unit

SM_API_test:TestSmPrincipalDirectionPairing, prog_test:my_test_extent3d, prog_test:my_test_vector2d, prog_test:my_test_surface_closest_point, prog_test:my_test_drop_point, prog_test:my_test_matrix